fix: correctly check antimagic brand conflicts for randarts
authoradvil <rawlins@gmail.com>
Tue, 27 Apr 2021 16:27:26 +0000 (12:27 -0400)
committeradvil <rawlins@gmail.com>
Tue, 27 Apr 2021 16:27:26 +0000 (12:27 -0400)
commit7bfb9e8c44a15aeb3c11461f1b69eb8fc6f6ac7c
tree145e2987091ddfbb827f561daf94021bda968f32
parent7ea0e0ed02b703c7ffde204f16dcbbea983619a2
fix: correctly check antimagic brand conflicts for randarts

The `get_weapon_brand` call here simply doesn't work, returning
SPWPN_NORMAL. I think this is because the brand prop is not yet set up
on `item` (past a point I stopped trying to figure out exactly what the
problem was). Possibly this check should be in
`_is_randart_conflicting` anyways?

I was able to replicate this in 0.25.1 with the seed from @Goratrix in
the issue: resolves #1322.
crawl-ref/source/artefact.cc